[?] Install conan-center hook by default on Modern images

[uilianries]

Description of Problem, Request, or Question

As all modern images are designed for Conan Center Index, and we need to check Conan Center hook before merging, installing it by default would help to prevent hooks errors before opening the PR.

[Croydon]

If you go ahead with this, please give the option to opt-out of it. Some hooks are good -if- you want to fulfill certain community standards, but there are also some hooks that make no sense outside of CCI. Like setting the homepage attribute to CCI.

The containers might be for CCI, but there is no reason to make it artificial harder to use them outside

[uilianries]

Yes, I agree. Also, we release one new image version per month, but hooks can be updated every week. I'm considering running an entrypoint when starting a new container, instead of installing the hook.

Or, we can install conan-center hook, but keep it disabled by default.

[jgsogo]

At this moment we are building two sets of images, ones like conanio/gcc10-ubuntu16 and others like conanio/gcc10-ubuntu16-jenkins, we are using the -jenkins ones in C3i, and we can assume these ones are specific for C3i usage. These images would be the ones to consider.

Pre-installing the hooks will save a lot of bandwith/time (needs benchmarking) because we are installing them so many times for every build in C3i (at least, once per configuration). The only drawback is, as said, "hooks can be updated every week".

If we preinstall hooks, we would need to regenerate docker images every time hooks are modified (and we want to start using that modification in c3i), now the deployment is automatic.

[uilianries]

As hooks gets more and more mature, we usually update them around once each month.

We will need to update Jenkins to trigger a new build for hooks release.

[jgsogo]

Also, changes to hooks don't need to be deployed right away. The same happens with changes merged to master in this repository, they are not automatically available in CCI.

We deploy at least once a month (with every Conan release) and we can deploy manually if needed. Maybe we can trigger the deployment process every week and that would be enough, no need to connect hooks repository to this CI.

[uilianries]

Maybe we can trigger the deployment process every week and that would be enough, no need to connect hooks repository to this CI.

That's a good option too. We can store the conan-center hook checksum and avoid extra builds when not needed.

[SSE4]

we might put that on hold for now. hooks aren't compatible with v2, and we don't know if they will be, or will we replace hooks by some pylint plug-ins.

[uilianries]

we might put that on hold for now. hooks aren't compatible with v2, and we don't know if they will be, or will we replace hooks by some pylint plug-ins.

Excellent point. Indeed we need to consider Conan V2.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically closed because it has not had recent activity. Thank you for your contributions.