conan-center-index icon indicating copy to clipboard operation
conan-center-index copied to clipboard

Published 20 hours ago • verified publisher icon conan-io

vulkan-validationlayers: update versions, improve package_type and test_package

Open valgur opened this issue 2 years ago • 2 comments

The package really only exports a VkLayer_khronos_validation runtime library and a .json manifest file, especially so after the utility library has been split off into vulkan-utility-libraries (#21059).

I adjusted the package_type accordingly to application and updated test_package to test the correct thing.

I intended to update the list of versions to match the other recently updated Vulkan and SPIRV packages (meaning only v1.3.239+ SDK versions), but:

  • 1.3.261.1 was not available in vulkan-loader for test_package.
  • 1.3.250.0 was not available in spirv-headers and spirv-tools.
  • 1.3.239.0 failed to load the validation layers in test_package and I'm not familiar enough with Vulkan to debug it.
  • 1.3.268.0 requires #21059.

valgur avatar Nov 30 '23 10:11 valgur

Conan v1 pipeline :x:

Failure in build 1 (d512800612f0ac2b5d2ecb53fcdf0c89715d535c):

  • vulkan-validationlayers/1.3.243.0: CI failed to create some packages (All logs)

    Logs for packageID 8c9083fe130334e9ff533757e5f3d1fe8abf4b0d: 
    [settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=9
os=Linux

    [...]
vulkan-validationlayers/1.3.243.0: Calling generate()
dpkg-query: no packages found matching libx11-dev
dpkg-query: no packages found matching libx11-xcb-dev
dpkg-query: no packages found matching libfontenc-dev
dpkg-query: no packages found matching libice-dev
dpkg-query: no packages found matching libsm-dev
dpkg-query: no packages found matching libxau-dev
dpkg-query: no packages found matching libxaw7-dev
dpkg-query: no packages found matching libxcomposite-dev
dpkg-query: no packages found matching libxcursor-dev
dpkg-query: no packages found matching libxdamage-dev
dpkg-query: no packages found matching libxdmcp-dev
dpkg-query: no packages found matching libxext-dev
dpkg-query: no packages found matching libxfixes-dev
dpkg-query: no packages found matching libxi-dev
dpkg-query: no packages found matching libxinerama-dev
dpkg-query: no packages found matching libxkbfile-dev
dpkg-query: no packages found matching libxmu-dev
dpkg-query: no packages found matching libxmuu-dev
dpkg-query: no packages found matching libxpm-dev
dpkg-query: no packages found matching libxrandr-dev
dpkg-query: no packages found matching libxrender-dev
dpkg-query: no packages found matching libxres-dev
dpkg-query: no packages found matching libxss-dev
dpkg-query: no packages found matching libxt-dev
dpkg-query: no packages found matching libxtst-dev
dpkg-query: no packages found matching libxv-dev
dpkg-query: no packages found matching libxvmc-dev
dpkg-query: no packages found matching libxxf86vm-dev
dpkg-query: no packages found matching libxcb-render0-dev
dpkg-query: no packages found matching libxcb-render-util0-dev
dpkg-query: no packages found matching libxcb-xkb-dev
dpkg-query: no packages found matching libxcb-icccm4-dev
dpkg-query: no packages found matching libxcb-image0-dev
dpkg-query: no packages found matching libxcb-keysyms1-dev
dpkg-query: no packages found matching libxcb-randr0-dev
dpkg-query: no packages found matching libxcb-shape0-dev
dpkg-query: no packages found matching libxcb-sync-dev
dpkg-query: no packages found matching libxcb-xfixes0-dev
dpkg-query: no packages found matching libxcb-xinerama0-dev
dpkg-query: no packages found matching libxcb-dri3-dev
dpkg-query: no packages found matching uuid-dev
dpkg-query: no packages found matching libxcb-cursor-dev
debconf: delaying package configuration, since apt-utils is not installed
dpkg-query: no packages found matching libxcb-util-dev
debconf: delaying package configuration, since apt-utils is not installed
vulkan-validationlayers/1.3.243.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
ERROR: vulkan-validationlayers/1.3.243.0: Error in generate() method, line 131
	tc.extra_cxxflags.append("-w")
	AttributeError: 'CMakeToolchain' object has no attribute 'extra_cxxflags'

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

conan-center-bot avatar Nov 30 '23 12:11 conan-center-bot

Conan v1 pipeline :x:

Failure in build 4 (61b3093e6da1921b1b7a032dc973dea583fc404a):

  • vulkan-validationlayers/1.3.243.0: CI failed to create some packages (All logs)

    Logs for packageID 127b1a48361f228cf17999bf2f2b1e161448fd4f: 
    [settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=7
os=Linux

    [...]
********************************************************************************
CMake Warning (dev) at scripts/CMakeLists.txt:93 (find_package):
  Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
  are removed.  Run "cmake --help-policy CMP0148" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning at /home/conan/w/prod-v1/bsr/65506/eccfa/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/127b1a48361f228cf17999bf2f2b1e161448fd4f/build/Release/generators/SPIRV-ToolsTargets.cmake:25 (message):
  Target name 'SPIRV-Tools' already exists.
Call Stack (most recent call first):
  /home/conan/w/prod-v1/bsr/65506/eccfa/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/127b1a48361f228cf17999bf2f2b1e161448fd4f/build/Release/generators/SPIRV-ToolsConfig.cmake:16 (include)
  layers/CMakeLists.txt:101 (find_package)


VulkanVL_generated_source target requires python 3
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_POLICY_DEFAULT_CMP0091


In file included from /home/conan/w/prod-v1/bsr/65506/eccfa/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/127b1a48361f228cf17999bf2f2b1e161448fd4f/src/layers/vk_layer_config.cpp:30:0:
/home/conan/w/prod-v1/bsr/65506/eccfa/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/127b1a48361f228cf17999bf2f2b1e161448fd4f/src/layers/vk_layer_utils.h: In function ‘constexpr VkExtent3D GetEffectiveExtent(const VkImageCreateInfo&, VkImageAspectFlags, uint32_t)’:
/home/conan/w/prod-v1/bsr/65506/eccfa/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/127b1a48361f228cf17999bf2f2b1e161448fd4f/src/layers/vk_layer_utils.h:399:27: error: call to non-constexpr function ‘bool FormatIsMultiplane(VkFormat)’
     if (FormatIsMultiplane(format)) {
         ~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /home/conan/w/prod-v1/bsr/65506/eccfa/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/127b1a48361f228cf17999bf2f2b1e161448fd4f/src/layers/generated/vk_safe_struct.cpp:28:0:
/home/conan/w/prod-v1/bsr/65506/eccfa/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/127b1a48361f228cf17999bf2f2b1e161448fd4f/src/layers/./vk_layer_utils.h: In function ‘constexpr VkExtent3D GetEffectiveExtent(const VkImageCreateInfo&, VkImageAspectFlags, uint32_t)’:
/home/conan/w/prod-v1/bsr/65506/eccfa/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/127b1a48361f228cf17999bf2f2b1e161448fd4f/src/layers/./vk_layer_utils.h:399:27: error: call to non-constexpr function ‘bool FormatIsMultiplane(VkFormat)’
     if (FormatIsMultiplane(format)) {
         ~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /home/conan/w/prod-v1/bsr/65506/eccfa/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/127b1a48361f228cf17999bf2f2b1e161448fd4f/src/layers/generated/vk_format_utils.cpp:25:0:
/home/conan/w/prod-v1/bsr/65506/eccfa/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/127b1a48361f228cf17999bf2f2b1e161448fd4f/src/layers/./vk_layer_utils.h: In function ‘constexpr VkExtent3D GetEffectiveExtent(const VkImageCreateInfo&, VkImageAspectFlags, uint32_t)’:
/home/conan/w/prod-v1/bsr/65506/eccfa/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/127b1a48361f228cf17999bf2f2b1e161448fd4f/src/layers/./vk_layer_utils.h:399:27: error: call to non-constexpr function ‘bool FormatIsMultiplane(VkFormat)’
     if (FormatIsMultiplane(format)) {
         ~~~~~~~~~~~~~~~~~~^~~~~~~~
make[2]: *** [layers/CMakeFiles/VkLayer_utils.dir/vk_layer_config.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [layers/CMakeFiles/VkLayer_utils.dir/generated/vk_format_utils.cpp.o] Error 1
make[2]: *** [layers/CMakeFiles/VkLayer_utils.dir/generated/vk_safe_struct.cpp.o] Error 1
make[1]: *** [layers/CMakeFiles/VkLayer_utils.dir/all] Error 2
make: *** [all] Error 2
vulkan-validationlayers/1.3.243.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
vulkan-validationlayers/1.3.243.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
vulkan-validationlayers/1.3.243.0: ERROR: Package '127b1a48361f228cf17999bf2f2b1e161448fd4f' build failed
vulkan-validationlayers/1.3.243.0: WARN: Build folder /home/conan/w/prod-v1/bsr/65506/eccfa/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/127b1a48361f228cf17999bf2f2b1e161448fd4f/build/Release
ERROR: vulkan-validationlayers/1.3.243.0: Error in build() method, line 157
	cmake.build()
	ConanException: Error 2 while executing cmake --build "/home/conan/w/prod-v1/bsr/65506/eccfa/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/127b1a48361f228cf17999bf2f2b1e161448fd4f/build/Release" '--' '-j3'

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

conan-center-bot avatar Dec 03 '23 16:12 conan-center-bot

Conan v1 pipeline :x:

Failure in build 2 (7dd4f01d8b1c9b1b618daa2602c91ce08d9f5c8c):

  • vulkan-validationlayers/1.3.243.0: CI failed to create some packages (All logs)

    Logs for packageID b3f9974305c102445ab08078b43913a119072257: 
    [settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=7
os=Linux

    [...]
  the cmake_policy command to set the policy and suppress this warning.

This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning at /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/build/Release/generators/SPIRV-ToolsTargets.cmake:25 (message):
  Target name 'SPIRV-Tools' already exists.
Call Stack (most recent call first):
  /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/build/Release/generators/SPIRV-ToolsConfig.cmake:16 (include)
  layers/CMakeLists.txt:101 (find_package)


VulkanVL_generated_source target requires python 3
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_POLICY_DEFAULT_CMP0091


In file included from /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/generated/vk_format_utils.cpp:25:0:
/home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/./vk_layer_utils.h: In function ‘constexpr VkExtent3D GetEffectiveExtent(const VkImageCreateInfo&, VkImageAspectFlags, uint32_t)’:
/home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/./vk_layer_utils.h:399:27: error: call to non-constexpr function ‘bool FormatIsMultiplane(VkFormat)’
     if (FormatIsMultiplane(format)) {
         ~~~~~~~~~~~~~~~~~~^~~~~~~~
make[2]: *** [layers/CMakeFiles/VkLayer_utils.dir/generated/vk_format_utils.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/vk_layer_config.cpp:30:0:
/home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/vk_layer_utils.h: In function ‘constexpr VkExtent3D GetEffectiveExtent(const VkImageCreateInfo&, VkImageAspectFlags, uint32_t)’:
/home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/vk_layer_utils.h:399:27: error: call to non-constexpr function ‘bool FormatIsMultiplane(VkFormat)’
     if (FormatIsMultiplane(format)) {
         ~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/generated/vk_safe_struct.cpp:28:0:
/home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/./vk_layer_utils.h: In function ‘constexpr VkExtent3D GetEffectiveExtent(const VkImageCreateInfo&, VkImageAspectFlags, uint32_t)’:
/home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/./vk_layer_utils.h:399:27: error: call to non-constexpr function ‘bool FormatIsMultiplane(VkFormat)’
     if (FormatIsMultiplane(format)) {
         ~~~~~~~~~~~~~~~~~~^~~~~~~~
make[2]: *** [layers/CMakeFiles/VkLayer_utils.dir/vk_layer_config.cpp.o] Error 1
make[2]: *** [layers/CMakeFiles/VkLayer_utils.dir/generated/vk_safe_struct.cpp.o] Error 1
make[1]: *** [layers/CMakeFiles/VkLayer_utils.dir/all] Error 2
make: *** [all] Error 2
WARN: **************************************************
WARN: *** Conan 1 is legacy and on a deprecation path **
WARN: *********** Please upgrade to Conan 2 ************
WARN: **************************************************
vulkan-validationlayers/1.3.243.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
vulkan-validationlayers/1.3.243.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
vulkan-validationlayers/1.3.243.0: ERROR: Package 'b3f9974305c102445ab08078b43913a119072257' build failed
vulkan-validationlayers/1.3.243.0: WARN: Build folder /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/build/Release
ERROR: vulkan-validationlayers/1.3.243.0: Error in build() method, line 173
	cmake.build()
	ConanException: Error 2 while executing cmake --build "/home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/build/Release" '--' '-j3'

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

conan-center-bot avatar Sep 18 '24 13:09 conan-center-bot

FTR this has served me well while debugging some Vulkan issues under macOS with MoltenVK. Happy to report all worked fine, thanks!

neobrain avatar Nov 22 '24 22:11 neobrain

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jan 24 '25 06:01 github-actions[bot]

@uilianries

valgur avatar Jan 24 '25 08:01 valgur

@valgur Please, let's focus on #21059 first. I had a further review yesterday and I may continue today.

uilianries avatar Jan 24 '25 09:01 uilianries

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Martin Valgur seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 09 '25 09:03 CLAassistant