openssl: Enable valid block of options for openssl >= 1.1.0

[tsondergaard]

The options zlib, rc4, rc5, and md2 have been deleted since commit fdc5ed56acf3 for versions != 1.0.2 and in a later commit for versions >= 1.1.0. Commit e3603397c434 introduced 3.x.x/conanfile.py where these options were no longer deleted. This means the options were only deleted for openssl >= 1.1.0 and openssl < 3.0.0 and there doesn't seem to be a reason for it.

Specify library name and version: lib/1.1.1

In #11439 I fixed the no_md2 option, but today I noticed the fix did not work for openssl/1.1.1 builds as the no_md2 option was deleted for openssl >= 1.1.0 and openssl < 3.0.0.

I've tested this change with this:

conan create . 1.1.1q@ts/test_no_md2 --build=missing --build=openssl -o openssl:shared=True -o openssl:no_md2=False -o openssl:no_rc4=True -o openssl:no_rc5=True -o openssl:no_zlib=True

---

• [x] I've read the guidelines for contributing.
• [x] I've followed the PEP8 style guides for Python code in the recipes.
• [x] I've used the latest Conan client version.
• [x] I've tried at least one configuration locally with the conan-center hook activated.

[ericLemanissierBot]

I detected other pull requests that are modifying openssl/1.x.x recipe:

• #14066
• #10939

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

[conan-center-bot]

All green in build 2 (d3c3659408eb9b65820a5c9215716bdb492cb760):

• openssl/1.1.1q@: All packages built successfully! (All logs)

  :small_orange_diamond: Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future. This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work. See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py", line 5, in <module>
      from conans import ConanFile, AutoToolsBuildEnvironment, tools
  ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

• openssl/1.1.0l@: All packages built successfully! (All logs)

  :small_orange_diamond: Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future. This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work. See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py", line 5, in <module>
      from conans import ConanFile, AutoToolsBuildEnvironment, tools
  ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

• openssl/3.0.3@: All packages built successfully! (All logs)

  :small_orange_diamond: Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future. This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work. See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11725/recipes/openssl/3.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11725/recipes/openssl/3.x.x/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-11725/recipes/openssl/3.x.x/conanfile.py", line 4, in <module>
      from conans import ConanFile, AutoToolsBuildEnvironment, tools
  ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

• openssl/1.1.1o@: All packages built successfully! (All logs)

  :small_orange_diamond: Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future. This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work. See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py", line 5, in <module>
      from conans import ConanFile, AutoToolsBuildEnvironment, tools
  ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

• openssl/1.1.1p@: All packages built successfully! (All logs)

  :small_orange_diamond: Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future. This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work. See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py", line 5, in <module>
      from conans import ConanFile, AutoToolsBuildEnvironment, tools
  ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

• openssl/1.0.2u@: All packages built successfully! (All logs)

  :small_orange_diamond: Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future. This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work. See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-11725/recipes/openssl/1.x.x/conanfile.py", line 5, in <module>
      from conans import ConanFile, AutoToolsBuildEnvironment, tools
  ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

• openssl/3.0.4@: All packages built successfully! (All logs)

  :small_orange_diamond: Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future. This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work. See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11725/recipes/openssl/3.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11725/recipes/openssl/3.x.x/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-11725/recipes/openssl/3.x.x/conanfile.py", line 4, in <module>
      from conans import ConanFile, AutoToolsBuildEnvironment, tools
  ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

• openssl/3.0.5@: All packages built successfully! (All logs)

  :small_orange_diamond: Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future. This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work. See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11725/recipes/openssl/3.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11725/recipes/openssl/3.x.x/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-11725/recipes/openssl/3.x.x/conanfile.py", line 4, in <module>
      from conans import ConanFile, AutoToolsBuildEnvironment, tools
  ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

[Croydon]

Pinging @uilianries as the author of https://github.com/conan-io/conan-center-index/commit/fdc5ed56acf3a4ccb68863a1d1ffce7bad591091

[Croydon]

https://github.com/openssl/openssl/blob/a3b54f0f5de1ad17889fd23aee7c230eefc300cd/INSTALL#L488

Documentation of 1.1.0 does not mention no-md2, no-rc5, no-zlib options

It does mention no-rc4 however. Either the documentation is incomplete or it does actually not exist. Did you double check?

[uilianries]

Need to read the original issue to understand it better: https://github.com/conan-io/conan-center-index/issues/108

Basically, those options are no longer available in Configure, which means, they are invalid.

[prince-chrismc]

Documentation of 1.1.0 does not mention no-md2, no-rc5

they have "enable" options https://github.com/openssl/openssl/blob/a3b54f0f5de1ad17889fd23aee7c230eefc300cd/INSTALL#L484

md2 looks correct but there no rc5 🤔 https://github.com/conan-io/conan-center-index/blob/d3c3659408eb9b65820a5c9215716bdb492cb760/recipes/openssl/1.x.x/conanfile.py#L517

[uilianries]

The documentation says something, but the Configure has another behavior.

[prince-chrismc]

I have been playing with this on my macbook trying to understand the combinations... overall this PR seems good.

• I can not build 1.1.1l 🤷 I'll need to test on another PC. (I am missing a system library with xcode 14)
• 1.0.2u required the no_rc4 to be False in order to pass :point_left: please test this to confirm

 4323  conan create . 1.1.1q@ --build=missing --build=openssl -o openssl:shared=True -o openssl:no_md2=False -o openssl:no_rc4=True -o openssl:no_rc5=True -o openssl:no_zlib=True
 4324  conan create . 1.1.1q@ --build=missing --build=openssl -o openssl:shared=True -o openssl:no_md2=True -o openssl:no_rc4=False -o openssl:no_rc5=False -o openssl:no_zlib=True
 4325  conan create . 1.1.0l@ --build=missing --build=openssl -o openssl:shared=True -o openssl:no_md2=False -o openssl:no_rc4=True -o openssl:no_rc5=True -o openssl:no_zlib=True
  # git stash
 4326  conan create . 1.1.0l@
 4327  conan create . 1.0.2u@ --build=missing --build=openssl -o openssl:shared=True -o openssl:no_md2=False -o openssl:no_rc4=True -o openssl:no_rc5=True -o openssl:no_zlib=True
 4328  conan create . 1.0.2u@ --build=missing --build=openssl -o openssl:shared=True -o openssl:no_md2=False -o openssl:no_rc4=False -o openssl:no_rc5=True -o openssl:no_zlib=True

[stale[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.