cmake-conan icon indicating copy to clipboard operation
cmake-conan copied to clipboard

Add HCOS to list of supported platforms

Open bwhitchurch opened this issue 1 year ago • 5 comments

Hello, I have been using conan and cmake to manage my builds and dependencies for projects targeting HCOS (honeycomb OS). I would like to add this name to the list of supported platforms.

bwhitchurch avatar Jul 13 '23 14:07 bwhitchurch

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 13 '23 14:07 CLAassistant

Okay, thank you very much. I had tried adding the entry to our local settings.yml as an option under both os_build and os_target. This works when we call conan and cmake separately, but it does not seem to be picked up by this script.

bwhitchurch avatar Jul 13 '23 23:07 bwhitchurch

``Okay, thank you very much. I had tried adding the entry to our local settings.yml as an option under both os_build and os_target.```

os_build and os_target are legacy, and shouldn't be used anymore. Cross-build scenarios should use the 2 profiles, with the "build" profile specified with -pr:b=mybuildprofile (can be the default one)

memsharded avatar Jul 13 '23 23:07 memsharded

customizing your own settings.yml would be enough.

So where should I add a new supported OS if entries under os_build, os_target, and os sections aren't getting picked up? I have a profile for this target already as well. I would appreciate if you could take a quick look and tell me what I have missed. Regardless, even with these configurations setup I still get

CMake Error at build/hcos_default/conan.cmake:105 (message): cmake system HCOS is not supported by conan.
Use one of Windows;Linux;Macos;Android;iOS;FreeBSD;WindowsStore;WindowsCE;watchOS;tvOS;FreeBSD;SunOS;AIX;Arduino;Emscripten;Neutrino

because the SUPPORTED_PLATFORMS list is not formed from the information in any of these local configuration files. hcos_profile

bwhitchurch avatar Jul 13 '23 23:07 bwhitchurch

So where should I add a new supported OS if entries under os_build, os_target, and os sections aren't getting picked up? I have a profile for this target already as well. I would appreciate if you could take a quick look and tell me what I have missed. Regardless, even with these configurations setup I still get

It should be added to the os section.

because the SUPPORTED_PLATFORMS list is not formed from the information in any of these local configuration files. hcos_profile

Yes, I am not saying that this wouldn't need an addition, but without adding it to Conan settings.yml first, it is pointless. Also, this kind of new features and support for 1.X series will typically not be considered. New things should target Conan 2.0 branches (also cmake-conan 2 branch, that will not have any constraint in the OS)

memsharded avatar Jul 16 '23 23:07 memsharded