cmake-conan icon indicating copy to clipboard operation
cmake-conan copied to clipboard

Published 20 hours ago • verified publisher icon conan-io

Improve cmake detection

Open buresu opened this issue 2 years ago • 1 comments

In some environments there is no path to the cmake. Because the CMAKE_COMMAND variable contains the path to the currently used cmake, set it to the CONAN_CMAKE_PROGRAM will solve this problem. Please see https://github.com/conan-io/conan/issues/7147

buresu avatar May 25 '22 05:05 buresu

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 25 '22 05:05 CLAassistant

Hi @buresu, Thanks for the contribution but I'm afraid we can't merge this, it's modifying the conan_cmake_run() function that is going to be deprecated soon and also will overwrite CONAN_CMAKE_PROGRAM that someone could be using. I think this issue is probably more related to something that has to be fixed in the build environment than something to fix in cmake-conan.

czoido avatar Nov 15 '22 10:11 czoido

@czoido Hi, Thank you for the review. I understood that, I will close this PR.

buresu avatar Nov 16 '22 04:11 buresu