emrichen icon indicating copy to clipboard operation
emrichen copied to clipboard

Add EnrichingProxy to run enrichment during !Lookups

Open akx opened this issue 3 years ago • 4 comments

It seems to work... Got ideas for better test cases?

Fixes #15

akx avatar Mar 22 '21 14:03 akx

@akx in your opinion, should this work (it doesn't)?

https://github.com/con2/emrichen/blob/ba1b01de6213d2cbd4d4c644259308a142b2df3d/tests/test_lookup.py#L102-L113

japsu avatar Mar 22 '21 14:03 japsu

Also once this is merged, let's release 0.3.0. We've added new tags and this change may introduce subtle changes in the degree of laziness, so incrementing the minor is warranted (would probably be 2.0.0 if we were already 1.x).

japsu avatar Mar 22 '21 15:03 japsu

See examples/peano.yml, uncomment five.

five:
- - []
two:
- - []

🤔⁉️

japsu avatar Mar 22 '21 15:03 japsu

@akx in your opinion, should this work (it doesn't)?

As far as correctness goes, it should, shouldn't it?

akx avatar Mar 22 '21 15:03 akx