mkpdfs-mkdocs-plugin icon indicating copy to clipboard operation
mkpdfs-mkdocs-plugin copied to clipboard

Multiple fixes & enhancements

Open dimrozakis opened this issue 2 years ago • 4 comments

Hi there @comwes.

First off, thanks for creating this plugin, I've been using it to build docs for more than a year and it's been really useful!

I just gathered some old & new fixes and improvements I've made, rebased them, and submitted them here to be included upstream.

Please check the commit log and review each commit separately. If you only want to merge some of these changes, let me know and I'll rebase the unwanted commits out of ths PR.

Thanks!

dimrozakis avatar Apr 04 '22 00:04 dimrozakis

Don't forget to squash your commits ;).

vladdoster avatar Apr 12 '22 14:04 vladdoster

Don't forget to squash your commits ;).

Hi @vladdoster. I submitted this PR with multiple commits because each one does a single, mostly independent thing and has a descriptive commit message. This should make review easier (by reviewing each smaller commit separately, as suggested in the PR description). Also, if only some but not all changes are desired, this makes it easier to exclude those commits that correspond to particular undesired changes during a later rebase.

Did you perhaps have a chance to review and/or test my suggested changes or have any other kind of feedback on them?

dimrozakis avatar Apr 12 '22 23:04 dimrozakis

Hi @comwes.

Have you had a chance to take a look at this MR? Do you have any feedback? Are you interested in merging any of the included changes?

dimrozakis avatar May 12 '22 23:05 dimrozakis

@dimrozakis My comment was in jest as I was having trouble using mkpdfs-mkdocs and came across this issue.

That said, this PR fixed my issues, and can vouch that it works.

vladdoster avatar May 13 '22 12:05 vladdoster