improve search

[asuworks]

trying to close https://github.com/comses/planning/issues/21

[asuworks]

thanks @asuworks this looks great! still need to test & deploy locally but some minor coding style recommendations.

I think we should try to keep our logging formats consistent throughout the codebase but the format strings are definitely easier to read with lots of parameters...

thanks @alee! fixed it!

[asuworks]

@sgfost

1. agree about the default ordering by Publish date: newest
2. agree about removing the filter tags and the red clear button from under the searchbar. Leave only the text: Displaying 4 of 4 results for 'lala' @alee ?
3. moving selected filters in the sidebar to the top would make the filtering ui elements jump up and down.. I'd say it's better to keep the selected filter tags at the bottom.

[sgfost]

the issue I have is that the whole sidebar is like 1000px tall without filters so you have to scroll up and down to do stuff, maybe it can be shrunk down to something more manageable? If the selected filters only appear when applied (which I think is what should happen) it may be less of an issue since the page would reload anyways.

Could also just apply on selection, I don't think we have nearly enough different filters to make that a problem, even without AJAX searching

[asuworks]

how about programming languages in 2 columns?

[asuworks]

we could also remove the "Publish a model" button (I think it is not very necessary there)

[sgfost]

the publish button should be somewhere on that page, maybe gets moved to whatever we replace that blue alert box with. The counts wrapping over looks a bit odd, what about collapsing it by default? Or showing just a few with a show more button.

Other stuff could probably be shrunk down too, padding, margins, text size, etc. The publish date filters can be together in one row

[asuworks]

[asuworks]

much nicer and shorter :)

[asuworks]

the wrapping is not nice, agree... maybe back to single column? The collapsing of the programming languages would complicate the ui I think...

[sgfost]

pretty sure thats the only link to publishing a model, I wouldn't want to suddenly move it. Regardless it still hardly fits on my screen

How does this UI look? I squished things down a bit and removed the apply button assuming we can apply everything on selection. If not, then the selected filters can sit at the bottom with the apply button since most screens should have the full thing in view. There should at least be a way to clear them from the top though

[asuworks]

@sgfost I implemented your version. When selecting a checkbox or a radio in the sidebar, the ui jumps down because the selected filters are populated at the top... not so nice... maybe put them back at the bottom?

[sgfost]

I had in mind only displaying them when they are actually applied. I suppose that may still pose an issue if things are applied on selection.. Its probably fine at the bottom as long as the whole thing isn't too tall

[asuworks]

Today we talked about showing selected filter badges in the sidebar on page load... I decided to get rid of them completely, since it seemed like an unnecessary duplication of the badges we display under the searchbar. What do you think?

[alee]

@all-contributors please add @sgfost for doc, review, maintenance, mentoring

[allcontributors[bot]]

@alee

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 2854

[alee]

@all-contributors please add @asuworks for code, doc

[allcontributors[bot]]

@alee

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 2854