karma-jspm icon indicating copy to clipboard operation
karma-jspm copied to clipboard

Remove extra function wrap

Open unional opened this issue 7 years ago • 3 comments

Fix #169

System.import() returns a promise. .then() accepts a promise in return, not a function.

unional avatar Jul 18 '16 18:07 unional

Raven

Number of Findings: 0

aviary-wf avatar Jul 18 '16 18:07 aviary-wf

karma.start() was being called automatically when certain time has passed, not from this line: https://github.com/Workiva/karma-jspm/blob/master/src/adapter.js#L65

If you added console.log('karma.start())` to it, you can see it is not being called.

This is because after the first call, the promiseChain resolved to a function with other System.import() calls, so they are "detached" and not tracked.

unional avatar Jul 18 '16 18:07 unional

Why there is no follow up for this much needed fix?

3cp avatar Aug 14 '17 23:08 3cp