nbval icon indicating copy to clipboard operation
nbval copied to clipboard

javascript not supported?

Open haraldschilly opened this issue 2 years ago • 2 comments

when I try testing a javascript notebook, all cells fail with

ERROR nbval-tests/22.04/javascript.ipynb::Cell 0 - KeyError: 'status'

that's how a cell looks like in the notebook – in case that helps

  {
   "cell_type": "code",
   "execution_count": 1,
   "metadata": {
    "collapsed": false
   },
   "outputs": [
    {
     "data": {
      "text/plain": [
       "'v16.16.0'"
      ]
     },
     "execution_count": 1,
     "metadata": {
     },
     "output_type": "execute_result"
    }
   ],
   "source": [
    "process.version"
   ]
  },

haraldschilly avatar Mar 30 '23 12:03 haraldschilly

Probably coming from this line:

https://github.com/computationalmodelling/nbval/blob/d7bc34893a9251fbfd4b270347197619c32fe6ea/nbval/kernel.py#L167

I would guess that can be relaxed with a .get() - do you want to make PR?

takluyver avatar Mar 30 '23 12:03 takluyver

Yes, that looks like where this is coming from. No to the PR, sorry :runner: :see_no_evil:

haraldschilly avatar Mar 30 '23 12:03 haraldschilly