nbval
nbval copied to clipboard
Fix: passing `fspath` to `from_parent`
fixing an error with probably latest ipython:
E TypeError: from_parent() missing 1 required keyword-only argument: 'fspath'
@fangohr @takluyver @vidartf could you pls have look at the proposed hotfix? :rabbit:
Gentle ping @fangohr @takluyver @vidartf, and could you approve Ci run? :chipmunk:
What version of pytest are you seeing this with? Is there a full traceback of the error? The current code looks like fspath is optional:
https://github.com/pytest-dev/pytest/blob/172c832cbdbfa407087ed6a895a298b48984da2a/src/_pytest/nodes.py#L633-L640
he current code looks like
fspath
is optional
Yes, but in the new version, it raises a different error see the comment with a trace: https://github.com/Lightning-AI/tutorials/pull/222#issuecomment-1463823867
I think I'm looking at the newest version of that code. Can I ask you to check what version you're running? pytest --version
I think I'm looking at the newest version of that code. Can I ask you to check what version you're running?
pytest --version
I had it in the log, but it seems that Azure keeps at most 2weeks' logs, and this is gone... I may try to reproduce it but not sure when as I already had to switch to fork with this fix