nbval icon indicating copy to clipboard operation
nbval copied to clipboard

Published 20 hours ago • verified publisher icon computationalmodelling

Document that --cov is supported

Open fangohr opened this issue 6 years ago • 9 comments

Example at https://twitter.com/ProfCompMod/status/1055845233295060992.

Attached file is notebook from that tweet (with wrong extension as GitHub didn't allow upload for ipynb file). nbval-coverage copy.ipynb.txt

fangohr avatar Oct 26 '18 15:10 fangohr

This is currently only mentioned in the README (https://github.com/computationalmodelling/nbval#coverage), but should also be mentioned in the docs. The attached notebook should be enough for now.

vidartf avatar Nov 01 '18 17:11 vidartf

Nice.

Can we move the notebook into the documentation?

fangohr avatar Nov 01 '18 20:11 fangohr

Is --cov-append supported?

I have a package that has most of its testing in standard .py files but we've been adding IPython features that need to be executed in a notebook. Ideally, I'd like to append the coverage report.

banesullivan avatar Feb 11 '19 02:02 banesullivan

Try it and let us know!

takluyver avatar Feb 11 '19 10:02 takluyver

--cov-append did not work for me

jetheurer avatar Feb 13 '19 11:02 jetheurer

I'm not overly familiar with --cov-append. Can someone give some more details on use cases? Which types of log outputs are you trying to combine?

vidartf avatar Feb 13 '19 12:02 vidartf

--cov stalls the whole notebook tests for me currently. They timeout and then error.

hameerabbasi avatar Apr 24 '19 09:04 hameerabbasi

@hameerabbasi Thanks for your feedback! Would you mind opening a new issue on this with some more details on what causes this problem (steps to reproduce)?

vidartf avatar Apr 24 '19 09:04 vidartf

Done in #116! Let me know if you need anything else to help diagnose the issue.

hameerabbasi avatar Apr 24 '19 10:04 hameerabbasi