saddle icon indicating copy to clipboard operation
saddle copied to clipboard

Add additional solc options on trace compilation

Open montyly opened this issue 5 years ago • 2 comments

Hi,

We are looking to integrate saddle in our compilation library. This would allow to support all our tools (including Slither, Echidna, or Manticore) out of the box.

Would it be possible to add abi,ast,userdoc,devdoc,hashes,compact-format to the solc options if the compilation is done with --trace ? https://github.com/compound-finance/saddle/blob/d5ee0ef85915c94f09515243623a4a7daa35230f/src/cli/commands/compile.ts#L18

This will simplify our integration.

Thank you

montyly avatar Aug 15 '20 17:08 montyly

Sure- do you think maybe this would be better to add solc_trace_args similar to solc_args in saddle.config.js so you could add whichever args you want via your config file?

See https://github.com/compound-finance/saddle/blob/master/saddle.config.js#L4

hayesgm avatar Aug 15 '20 20:08 hayesgm

Thanks @hayesgm for the link.

So that would work with manual editing, but it will prevent a more transparent usage.

Ex: as a user I want to run some_tool [saddle project] without having to change my saddle.config.js to fit the external tool needs.

If we can have access to the elements listed above, I think that would facilitate any third party tool integration. It's the way we integrated the other frameworks.

montyly avatar Sep 04 '20 14:09 montyly