comet icon indicating copy to clipboard operation
comet copied to clipboard

OZ Improvements

Open peersky opened this issue 1 year ago • 3 comments

This PR contains improvements we did on OpenZeppelin side to use comet repo and particularly spider tool useful in monitoring stack CI/CD pipeline.

Changes consist of:

  • Replaced hardcoded URL in favor of BASE_RPC_URL environment variable for base network
  • Replaced hardcoded URL in favor of SCROLL_RPC_URL environment variable for scroll network
  • Changed Scroll rpc endpoint to use SCROLLSCAN_KEY instead of ETHERSCAN_KEY
  • Added contract creation code scraping strategy to pullFirstInternalTransactionForContract

Merging this PR implies that maintainers must agree to update env variables in repository:

  • [x] set BASE_RPC_URL
  • [x] set SCROLL_RPC_URL
  • [x] set SCROLLSCAN_KEY

Motivation

  • We are using other RPC providers to crawl data and using generic <NETWORK>_RPC_URL allows us easier integrate
  • We've observed highly unstable operation of Scroll network crawling
  • We've observed highly unstable internal transaction crawling often failing

It resolves:

  • #825
  • #840

It surpasses:

  • #841

peersky avatar Apr 19 '24 09:04 peersky

@peersky thanks for making these changes. The changes LGTM, but you'll need to also update the Github workflow files to use these new env vars. Places like here and here.

kevincheng96 avatar Apr 22 '24 17:04 kevincheng96

@peersky thanks for making these changes. The changes LGTM, but you'll need to also update the Github workflow files to use these new env vars. Places like here and here.

added

peersky avatar Apr 23 '24 04:04 peersky

@kevincheng96 bump

peersky avatar May 14 '24 15:05 peersky