OZ Improvements
This PR contains improvements we did on OpenZeppelin side to use comet repo and particularly spider tool useful in monitoring stack CI/CD pipeline.
Changes consist of:
- Replaced hardcoded URL in favor of
BASE_RPC_URLenvironment variable forbasenetwork - Replaced hardcoded URL in favor of
SCROLL_RPC_URLenvironment variable forscrollnetwork - Changed Scroll rpc endpoint to use
SCROLLSCAN_KEYinstead ofETHERSCAN_KEY - Added contract creation code scraping strategy to
pullFirstInternalTransactionForContract
Merging this PR implies that maintainers must agree to update env variables in repository:
- [x] set
BASE_RPC_URL - [x] set
SCROLL_RPC_URL - [x] set
SCROLLSCAN_KEY
Motivation
- We are using other RPC providers to crawl data and using generic
<NETWORK>_RPC_URLallows us easier integrate - We've observed highly unstable operation of Scroll network crawling
- We've observed highly unstable internal transaction crawling often failing
It resolves:
- #825
- #840
It surpasses:
- #841
@peersky thanks for making these changes. The changes LGTM, but you'll need to also update the Github workflow files to use these new env vars. Places like here and here.
@peersky thanks for making these changes. The changes LGTM, but you'll need to also update the Github workflow files to use these new env vars. Places like here and here.
added
@kevincheng96 bump