streamly

streamly copied to clipboard

`unsafeThaw` should be called `coerce` or `cast`

1

adithyaov

Move them to the Array module. Also move the adaptC/adaptCG parser adapting functions to the relevant array modules.

harendra-kumar

``` parList => parConcatList : in line with parConcatMap. sampleIntervalStart => sampleIntervalHead : use noun for `Start` to avoid confusion sampleIntervalEnd => sampleIntervalTail sampleBurstStart => sampleBurstHead sampleBurstEnd => sampleBurstTail ```

harendra-kumar

The CI should fail if any external API has changed and he major version of the package is not bumped.

adithyaov

`unpin` operation should check the size of array before unpinning

1

GHC always pins memory > 4k (or 3k). You cannot unpin a large block.

adithyaov

Serialization template haskell helpers should handle constructor order and name change

2

We should have another config option that can define the order of constructors so the tag for the constructor is stable. For example, say we have a datatype: ``` data...

adithyaov

Unreproducible test failure

1

First seen at commit 350b6acae : ``` Failures: Streamly/Test/Unicode/Stream.hs:177:9: 1) Unicode.Stream, UTF8 - Encoding / Decoding, Arrays Streamly.Data.String.lines == Prelude.lines Assertion failed (after 584 tests): [111,74,18,114,114,246,44,86,35,209,255,112,6,60,174,59,132,154,226,252,199,212,251,28,42,66,99,32,168,104,253,69,83,11,204,31,196,230,108,29,70,236,204,117,66,71,126,154,46,228,238,157,11,39,251,207,151,177,9,109,64,112,173,11,125,162,19,108,201,110] To rerun use: --match...

harendra-kumar

Along with this, we will need to add a cycle detection as well.

harendra-kumar

Read dir performance improvements

1

harendra-kumar

Use ByteArray# instead of MutableByteArray# in the immutable Array

1

Freeze it before finalizing the array.

harendra-kumar