streamly icon indicating copy to clipboard operation
streamly copied to clipboard

Rename MutArray APIs to follow naming conventions

Open harendra-kumar opened this issue 1 year ago • 1 comments

castUnsafe => unsafeCast
newArrayWith => emptyWithAligned
getSliceUnsafe => unsafeGetSlice
createOfWith => createWithOf (argument order convention)
putIndexUnsafe => unsafePutIndex
modifyIndexUnsafe => unsafeModifyIndex
getIndexUnsafe => unsafeGetIndex
realloc => reallocBytes
reallocWith => reallocBytesWith
snocUnsafe => unsafeSnoc
spliceUnsafe => unsafeSplice
pokeAppend   => poke
pokeAppendMay  => pokeMay
pokeSkipUnsafe => unsafePokeSkip
peekUncons   => peek
peekUnconsUnsafe => unsafePeek
peekSkipUnsafe  => unsafePeekSkip

pinnedWriteNAligned is listed under deprecated but not marked DEPRECATED.

harendra-kumar avatar Jul 19 '24 03:07 harendra-kumar

Suggestions:

pokeAppend => snocBytes, snocAsBytes
pokeAppendMay => snocBytesMay, snocAsBytesMay

adithyaov avatar Jul 22 '24 19:07 adithyaov

This is already done in https://github.com/composewell/streamly/pull/2792

adithyaov avatar Sep 10 '24 12:09 adithyaov