satis icon indicating copy to clipboard operation
satis copied to clipboard

Do we need to load all packages each times with providers enabled ?

Open glickel opened this issue 6 years ago • 1 comments

Hello, On BuildCommand if we have a package/repository filter, we load all packages to dump them with the PackagesBuilder :

if ($packageSelection->hasFilterForPackages() || $packageSelection->hasRepositoryFilter()) {
    // in case of an active filter we need to load the dumped packages.json and merge the
    // updated packages in
    $oldPackages = $packageSelection->load();
    $packages += $oldPackages;
    ksort($packages);
}

$packagesBuilder = new PackagesBuilder($output, $outputDir, $config, $skipErrors);
$packagesBuilder->dump($packages);

Is it really needed if providers option is enabled ? If no, I can create a pull request to change the code

glickel avatar Jul 26 '19 15:07 glickel

Hello,

I'm proposing a change here #650 that could fix your issue

giem-git avatar May 21 '21 08:05 giem-git