packagist icon indicating copy to clipboard operation
packagist copied to clipboard

Pager doesn't work on extensions list

Open remicollet opened this issue 1 year ago • 4 comments

Example https://packagist.org/extensions?page=2

remicollet avatar Oct 08 '24 09:10 remicollet

Looks like the extension controller is missing handling of current page / per page entirely, can probably just copy that over from https://github.com/composer/packagist/blob/1f080cd8e0d896772a830a1c7fb6af3e4c4f65e5/src/Controller/ExploreController.php#L69

naderman avatar Oct 08 '24 09:10 naderman

AFAICT, it currently returns an unpaginated list, so all extensions are returned at once (this is probably not a good idea for scalability)

stof avatar Oct 08 '24 10:10 stof

hmm, no. even worse. It loads unpaginated data and then creates a pagerfanta object but without configuring it...

stof avatar Oct 08 '24 10:10 stof

This was all quickly glued together PoC code. Good to see more extensions coming, so I guess it's time to clean this up a bit :)

Seldaek avatar Oct 11 '24 22:10 Seldaek

Fixed the search as well to search only extensions now when on the extension page.

Seldaek avatar Oct 28 '24 22:10 Seldaek