composer icon indicating copy to clipboard operation
composer copied to clipboard

feat: Upgrade to json-schema v6

Open DannyvdSluijs opened this issue 1 year ago • 3 comments

This draft PR updates the justinrainbow/json-schema to 6.0.0-beta as some early smoke testing.

DannyvdSluijs avatar Jul 09 '24 07:07 DannyvdSluijs

composer.lock

Package changes

Package Operation From To About
icecave/parity add - 1.0.0 view code - License: MIT License
icecave/repr add - 1.0.1 view code - License: MIT License
marc-mabe/php-enum add - v4.7.0 view code - License: BSD 3-Clause "New" or "Revised" License
justinrainbow/json-schema upgrade 5.3.0 6.0.0-beta diff

Settings · Docs · Powered by Private Packagist

private-packagist[bot] avatar Jul 09 '24 07:07 private-packagist[bot]

Oh.. new dependencies in v6, I hadn't noticed that until now. Not a fan of that, but so it goes. On the other hand Composer can probably stick to v5 for now as we don't really need anything else feature wise..

Seldaek avatar Jul 10 '24 07:07 Seldaek

Oh.. new dependencies in v6, I hadn't noticed that until now. Not a fan of that, but so it goes. On the other hand Composer can probably stick to v5 for now as we don't really need anything else feature wise..

I can see you point. At some point we maybe should (re-) evaluate them. Especially the icecave/* seems the odd one out as it is advertised as a A customizable deep comparison library. Which seems unneeded at a quick glance.

Besides that I tried to find the cause of the test failures but didn't find them yet (only done minimal effort for now as I'm trying to smoke test a couple of dependants)

DannyvdSluijs avatar Jul 15 '24 17:07 DannyvdSluijs