conformance-tests icon indicating copy to clipboard operation
conformance-tests copied to clipboard

Add Go modules to vendor directory

Open chris-crone opened this issue 5 years ago • 2 comments

Chatting to @thaJeztah and @justincormack, for things that we expect to ship as a binary it makes more sense to include the modules as vendored code.

This also speeds up the build for the CI as we don't need to fetch anything.

chris-crone avatar Mar 17 '20 10:03 chris-crone

This also speeds up the build for the CI as we don't need to fetch anything.

But you have to checkout vendor/, which will later include all previous versions of your dependencies with your git history, while go runtime on CI nodes could benefit go mod cache for same purpose.

ndeloof avatar Mar 17 '20 15:03 ndeloof

It actually appears that you do need the GOFLAGS=-mod=vendor as otherwise the modules are pulled.

chris-crone avatar Mar 17 '20 16:03 chris-crone