gha-setup-swift

gha-setup-swift copied to clipboard

Use /etc/os-release for identifying the Linux distribution rather than `lsb_release`. Co-Authored-By: Gwynne Raskind

compnerd

https://github.com/kelvin13/swift-json/blob/master/.github/workflows/build.yml#L38 as an example

compnerd

- Use `/etc/os-release` to check Linux versions (`lsb_release` is obsolete and not always available) - Iinstall Linux toolchain to better prefix - Fix GHA syntax of Linux error message -...

gwynne

Confusing options

10

If I give a tag name, what is the branch name used for (and vice-versa)? Either one uniquely identifies a release. Please clarify in the README.

dabrahams

This method of getting `TOOLCHAINS` set up is obviously too fragile and hacky in the long run, but seems to be working for now. Please squash-merge

dabrahams

Makes this action not depend on prior vsdevenv setup.

1

dabrahams

$env:Path left with the wrong link.exe being found first

3

[This run](https://github.com/hylo-lang/Swifty-LLVM/actions/runs/8207602540/workflow) demonstrates. Follow the link to the workflow file if you need to reproduce elsewhere. Maybe you could use this as a unit test case for this action.

dabrahams