compiler-explorer icon indicating copy to clipboard operation
compiler-explorer copied to clipboard

[REQUEST]: Support LLVM-MCA for armv8-a clang

Open sjoerdmeijer opened this issue 2 years ago • 7 comments

Is your feature request related to a problem? Please describe

LLVM-MCA is supported for X86-64 clang compilers, but not for armv8-a clang:

"The current language or compiler does not support this tool"

Describe the solution you'd like

LLVM-MCA is supported for armv8-a. Could support be added for armv8-a?

Describe alternatives you've considered

n/a

Additional context

Not applicable

sjoerdmeijer avatar Oct 25 '23 07:10 sjoerdmeijer

Involves removing the mention of arm and aarch here https://github.com/compiler-explorer/compiler-explorer/blob/be5a9802470986942c572dd14f2a47ab14002699/etc/config/c%2B%2B.amazon.properties#L4512 (5 years ago it did not support arm and we intentionally disabled it for that reason)

partouf avatar Oct 25 '23 08:10 partouf

Makes sense. Not sure about arm though, that might not be very well supported, but agree that we want to remove aarch from that list.

sjoerdmeijer avatar Oct 25 '23 08:10 sjoerdmeijer

@partouf: are you happy if I create a merge request for this? The fix looks very simple. Testing would be more challenging for me, but installing compiler explorer locally and giving it a try looks very doable.

sjoerdmeijer avatar Oct 27 '23 09:10 sjoerdmeijer

@partouf: are you happy if I create a merge request for this? The fix looks very simple. Testing would be more challenging for me, but installing compiler explorer locally and giving it a try looks very doable.

please do, no need for testing really, we can do that more quickly

partouf avatar Oct 27 '23 10:10 partouf

Is this now supported on compiler explorer? I might misunderstood the initial request or the PR, but when I look at the example here: https://godbolt.org/z/f6d9h1Gvz I do think I can use llvm-mca.

FabianSchuetze avatar Feb 09 '24 18:02 FabianSchuetze

Doesn't look like it, not sure what's going on. Thanks for the ping, will investigate later

partouf avatar Feb 09 '24 18:02 partouf

Thanks a lot, @partouf , very much appreciated.

FabianSchuetze avatar Feb 10 '24 07:02 FabianSchuetze

Congratulations to being on c++cast and thanks for all the nice discussions, @partouf . Do you have an idea what the issue with mca for arm is?

FabianSchuetze avatar Feb 24 '24 10:02 FabianSchuetze

this should be fixed now and it is live, be aware that you do need to pass --march and --mcpu to llvm-mca before it understands what's going on

partouf avatar Feb 28 '24 21:02 partouf

Fantastic - many thanks!

FabianSchuetze avatar Feb 29 '24 08:02 FabianSchuetze