asm-parser icon indicating copy to clipboard operation
asm-parser copied to clipboard

Published 20 hours ago • verified publisher icon compiler-explorer

[WIP] Fix 4848

Open partouf opened this issue 1 year ago • 4 comments

Aiming to fix https://github.com/compiler-explorer/compiler-explorer/issues/4848

Issue is: function starts with library file

Discussed before elsewhere, but to really fix this we must:

  • Move the library filter to a post-process step
  • Only eliminate the function that has no usercode at all, otherwise leave it

partouf avatar Mar 11 '23 11:03 partouf

Not sure what the fix was supposed to do. The problem (the rdtsc drop) persists even when checking off the library filter.

OfekShilon avatar Nov 10 '23 16:11 OfekShilon

  • Only eliminate the function that has no usercode at all, otherwise leave it

Correct, but the part that wasn't implemented here was the 2nd bulletpoint Only eliminate the function that has no usercode at all, otherwise leave it

partouf avatar Nov 10 '23 16:11 partouf

(And it had a bug where libcode was sometimes always filtered it without looking at the filter setting)

partouf avatar Nov 10 '23 16:11 partouf

But am extremely fuzzy on the details, i shouldve continued this pr when i understood what was going on

partouf avatar Nov 10 '23 16:11 partouf