ngrammatic icon indicating copy to clipboard operation
ngrammatic copied to clipboard

Fixed issues dependant libraries and rerun benchmarks

Open LucaCappelletti94 opened this issue 1 year ago • 0 comments

Hi @compenguy, I have some news - I have worked with @zommiommy to finish updating the integration of libraries like sux-rs and webgraph-rs. Now all tests pass, except for everything regarding trie-rs.

Now, I have made a pull request to the trie repo and all of its dependencies. Still, I have not received any reply from the authors there, and as trie-rs did not fare positively in our benchmarks I think we can remove it altogether as the RCL trumps trie in all relevant contexts.

Tomorrow I will clean up the repo from all references of trie-rs and update the README accordingly. One big caveat is that in the Cargo.toml at this time there are still several GitHub crates, as some dependency versions have yet to be published on crates.io - we may have to wait a little bit for those to become stable.

New benchmarks:

  • Memory requirements: https://github.com/LucaCappelletti94/ngrammatic/blob/master/benchmarks/visualizations.ipynb
  • Time requirements: https://github.com/LucaCappelletti94/ngrammatic/blob/master/benches/visualizations.ipynb

LucaCappelletti94 avatar Jul 26 '24 19:07 LucaCappelletti94