Will Page

Results 22 comments of Will Page

To be clear, this isn't even just about respecting rust-version in the Cargo.toml. If I set my rustup toolchain to 1.72 and use this Cargo.toml: ``` [package] name = "msrv-resolve-cargo-platform"...

Apologies - the failure I'm reporting looks similar, but is not new - this has apparently always been broken.

> Ping @compenguy. Just checking in to see if you are still interested in working on this, or if you had any questions we could help with. I'm still on...

> Hi @compenguy, just checking in to see if you are still working on this issue. If not, may I handle the remaining parts? Thank you. I appreciate the offer,...

> * Do we want to support multiple `-C` specified as how `git` and `make` do? I have no idea if that is a useful behaviour. It seems to be...

I'm pretty happy with the changes overall, just some minor fixes for outdated comments, and trying to close the (unlikely) gap of a 0-arity ngram.

> @compenguy if you are curious, you can take a look at the ongoing benchmarks here: https://github.com/LucaCappelletti94/ngrammatic/tree/master/benchmarks I see benchmark times for building the corpus, but how does this affect...

It looks like there are merge conflicts that need resolving. I haven't yet looked at the conflicts, buy the commit history shows the evolution of your thinking, with your mistakes...

I merged this PR to make it easier for you to work on. There's still issues with it, including test failures: ``` failures: src/corpus_par_from.rs - corpus_par_from::Corpus::par_from (line 111) src/lib.rs -...

Let me see if I understand where you're going with this... ``` pub fn search_with_warp(&self, text: &str, warp: f32, threshold: f32) -> Vec { ... for gram in item.grams.keys() {...