polis icon indicating copy to clipboard operation
polis copied to clipboard

Fix regression: Don't apply vote for seed comments by admin

Open patcon opened this issue 5 years ago • 5 comments

This had been fixed in the old interface: https://github.com/pol-is/polisServer/issues/128#issuecomment-620936598

But seems like there's been a regression, as I've discovered while writing tests that seed comments, which are now created with a vote attached, instead of a null vote.

patcon avatar Jun 27 '20 16:06 patcon

@colinmegill can you confirm this is a regression and not something that was on purpose?

patcon avatar Jun 27 '20 16:06 patcon

Not intended to be a change!

On Sat, Jun 27, 2020 at 12:29 PM Patrick Connolly [email protected] wrote:

@colinmegill https://github.com/colinmegill can you confirm this is a regression and not something that was on purpose?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pol-is/polisServer/issues/373#issuecomment-650582694, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANQGGJZSZ4LEYLJUSY52U3RYYM45ANCNFSM4OKDFL2A .

colinmegill avatar Jun 27 '20 20:06 colinmegill

Odd. Seems that on pol.is domain itslef, using my [elevated?] account, a vote is not added for seed comments. But locally, I've verified that it does implicitly get a vote... hm..

@colinmegill Might I have a different account type on the prod website, that might explain this?

E.g, this convo https://pol.is/6znrb6rbfz

patcon avatar Jun 30 '20 21:06 patcon

Confirmed on production that seed statements don't get an implicit vote.

patcon avatar Aug 01 '20 20:08 patcon

Confirmed again on local mainline that seed comments DO get an implicit yes vote on local dev.

patcon avatar Aug 01 '20 20:08 patcon