polis icon indicating copy to clipboard operation
polis copied to clipboard

Resolve remainder of hardcoded pol.is domain configuration issues

Open patcon opened this issue 5 years ago • 3 comments

Finishing work started in https://github.com/pol-is/polisServer/pull/290 with server component.

There is some prior work done in PDIS fork that could guide this: https://github.com/pol-is/polisServer/issues/232

cc: @metasoarous

patcon avatar Jun 06 '20 22:06 patcon

@metasoarous had thoughts here

My sense is that we shouldn't even be defaulting to server = "https://pol.is", basically ever, but require any install to manually specify the domain. Hopefully this will simplify things overall.

For now though this PR solves a problem, and I'd rather have it in than not.

patcon avatar Jun 06 '20 22:06 patcon

We should default to "localhost" instead of defaulting to "pol.is", unless it's pointing to docs or something.

ballPointPenguin avatar Apr 05 '23 23:04 ballPointPenguin

[ ] Take a note of every remaining hard coded url in the codebase for a last check. "No pol.is sprinkled in the code :-)" @ballPointPenguin

xeeg avatar Apr 05 '23 23:04 xeeg