polis icon indicating copy to clipboard operation
polis copied to clipboard

added static build/deploy to Makefile

Open crkrenn opened this issue 2 years ago • 3 comments

I think this could replace the bin/build-static-assets.clj and bin/deploy-static-assets.clj scripts. Am I missing anything?

crkrenn avatar Jan 08 '23 16:01 crkrenn

I made some small improvements here and tested it out. I think we should go forward, it's quite useful. https://github.com/compdemocracy/polis/commit/a9fee332f0401ccba1dd79c8edc858ba6940491d

branch: https://github.com/compdemocracy/polis/tree/ck/build_and_deploy_makefile

ballPointPenguin avatar Nov 10 '23 11:11 ballPointPenguin

One thing is that not all s3 buckets support ACL so that argument was causing my run to fail. I wonder if it is more typical to set bucket policy for public access and avoid object-level ACL flags (?) somehow that's what I ended up with

ballPointPenguin avatar Nov 10 '23 11:11 ballPointPenguin

@ballPointPenguin Yeah; Confirming that it's not possible to serve static assets via S3 without the entire bucket public. Maybe this used to be possible, but not relevant at the moment.

metasoarous avatar Nov 13 '23 20:11 metasoarous