@sevazhidkov's ru strings PR - CI fix

[metasoarous]

After merging #1362 (HT @raulsperoni), @sevazhidkov's #1354 is still failing CI, so trying to manually merge in those changes to see if that will fix the issue.

[patcon]

Hi :) Not sure if this is still relevant, but just an FYI that when a run fails, docker container logs are printed that could give a hint as to what's happening.

I'm noticing this https://github.com/compdemocracy/polis/runs/5728322765?check_suite_focus=true#step:15:639

In case logs get scrubbed, transcript:

polis-server            | ErrorClass [ApiError]: User Rate Limit Exceeded
polis-server            |     at Object.parseHttpRespBody (/app/node_modules/@google-cloud/common/src/util.js:192:30)
polis-server            |     at Object.handleResp (/app/node_modules/@google-cloud/common/src/util.js:132:18)
polis-server            |     at /app/node_modules/@google-cloud/common/src/util.js:465:12
polis-server            |     at Request.onResponse [as _callback] (/app/node_modules/retry-request/index.js:195:7)
polis-server            |     at Request.self.callback (/app/node_modules/request/request.js:185:22)
polis-server            |     at Request.emit (events.js:315:20)
polis-server            |     at Request.EventEmitter.emit (domain.js:486:12)
polis-server            |     at Request.<anonymous> (/app/node_modules/request/request.js:1154:10)
polis-server            |     at Request.emit (events.js:315:20)
polis-server            |     at Request.EventEmitter.emit (domain.js:486:12)
polis-server            |     at Gunzip.<anonymous> (/app/node_modules/request/request.js:1076:12)
polis-server            |     at Object.onceWrapper (events.js:421:28)
polis-server            |     at Gunzip.emit (events.js:315:20)
polis-server            |     at Gunzip.EventEmitter.emit (domain.js:486:12)
polis-server            |     at endReadableNT (_stream_readable.js:1327:12)
polis-server            |     at processTicksAndRejections (internal/process/task_queues.js:80:21)
polis-server            | From previous event:
polis-server            |     at /app/dist/src/server.js:6239:40
polis-server            |     at processTicksAndRejections (internal/process/task_queues.js:93:5) {
polis-server            |   code: 403,
polis-server            |   errors: [
polis-server            |     {
polis-server            |       message: 'User Rate Limit Exceeded',
polis-server            |       domain: 'usageLimits',
polis-server            |       reason: 'userRateLimitExceeded'
polis-server            |     }
polis-server            |   ],
polis-server            |   response: undefined
polis-server            | }
polis-server            | 3

So it looks like the google translate API credentials are no longer working. I forget exactly how that was set up, but I imagine it is no longer connected.

In a pinch, you can prob temporarily circumvent the issue by disabling the tests related to Google Translation. But I'd recommend not delaying if possible, as it seems pretty easy for coverage like this to fall into never getting fixed (with it's awkward 3rd-party credential requirement). And the comment translation seems like really valuable functionality that might easily break and not be noticed in normal manual QA testing. I recall documenting Google account setup pretty well: https://github.com/compdemocracy/polis/blob/dev/docs/deployment.md#enabling-comment-translation

https://github.com/compdemocracy/polis/blob/332b915788ac97efe426411e284b49cd22438828/.github/workflows/cypress-tests.yml#L44-L48

(This might not be the only issue in there, just the first I saw..!)

Anyhow, hope you're well, Chris

[metasoarous]

This was just a test PR, and has already been merged elsewhere, so closing now.

Thanks