polis icon indicating copy to clipboard operation
polis copied to clipboard

Use the configured domain setting in a couple more places.

Open pluby opened this issue 3 years ago • 2 comments

Use the custom domain for a couple of key areas where it's particularly useful:

  • Embed code snippet
  • Link in moderation URL

One of the key changes is the removal of the function createProdModerationUrl in favour of createModerationUrl. it (createProdModerationUrl) is only used in one place.

pluby avatar Jan 06 '22 22:01 pluby

Also, @metasoarous before you merge, can you approve running of actions for @pluby? GitHub ratcheted up restrictions on first-time contributors due to cryptominers.

But our CI runs are not a security risk, and I feel we should try to approve new contrubutors' PRs as quickly as possible (ie. no need to review first) so that tests can run and first-timers have feedback and a smooth experience (and so they're not waiting on someone like me to run locally in order to give a code review) 😃

patcon avatar Jan 06 '22 23:01 patcon

I think this should be good for review now.

pluby avatar Jan 10 '22 10:01 pluby

This has already been captured in the config updates.

xeeg avatar Apr 05 '23 23:04 xeeg