compas_rrc
compas_rrc copied to clipboard
No exception raised when using send_and_wait and custom instruction
When using a custom instruction based on the RRC custom_instruction
template, that sends feedback i.e. parse_feedback
, the custom instruction can get stuck and hang forever.
The culprit is the incorrect parsing of the feedback values, that normally would raise a Python Exception. However in conjunction with rrc's send_and_wait
no Exception is raised whatsoever.
Expected Result
Python Exception raised
Actual Result
Nothing, script gets stuck.
Reproduction Steps
Parse a feedback incorrectly e.g. string_values[0]
when string_values
is an empty list
System Information
Operating System name and version, Python version, etc. compas_rrc v 1.1.0
@fleischp let's test this on Friday, I believe this is already fixed in the webservices
branch.
Fixed in the commit above, will be released in the next version!