compas_rrc icon indicating copy to clipboard operation
compas_rrc copied to clipboard

No exception raised when using send_and_wait and custom instruction

Open mattiskoh opened this issue 2 years ago • 2 comments

When using a custom instruction based on the RRC custom_instruction template, that sends feedback i.e. parse_feedback, the custom instruction can get stuck and hang forever.

The culprit is the incorrect parsing of the feedback values, that normally would raise a Python Exception. However in conjunction with rrc's send_and_wait no Exception is raised whatsoever.

Expected Result

Python Exception raised

Actual Result

Nothing, script gets stuck.

Reproduction Steps

Parse a feedback incorrectly e.g. string_values[0] when string_values is an empty list

System Information

Operating System name and version, Python version, etc. compas_rrc v 1.1.0

mattiskoh avatar Feb 10 '23 09:02 mattiskoh

@fleischp let's test this on Friday, I believe this is already fixed in the webservices branch.

gonzalocasas avatar Feb 15 '23 13:02 gonzalocasas

Fixed in the commit above, will be released in the next version!

gonzalocasas avatar Feb 17 '23 08:02 gonzalocasas