compas
compas copied to clipboard
Predicates2 new methods addition
I added new predicates in predicates_2
for both point/polygon(XY) and polygon/polygon(XY): polygon_to_polygon_relationship_xy
, point_to_polygon_relationship_xy
, is_intersection_polygon_polygon_xy
Full documentation provided in the methods comments. There are on purpose overlaps in what the methods are doing, for instance 'polygon_to_polygon_relationship_xy' first checks for intersection, then for containment, and if not deducts that the polygon is outside instead of calling separate methods. Separate methods ('is_polygon_in_polygon_xy', 'is_intersection_polygon_polygon_xy', ...) are still useful when looking for a True/False answer only.
What type of change is this?
- [ ] Bug fix in a backwards-compatible manner.
- [x ] New feature in a backwards-compatible manner.
- [ ] Breaking change: bug fix or new feature that involve incompatible API changes.
- [ ] Other (e.g. doc update, configuration, etc)
Checklist
Put an x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
- [x ] I added a line to the
CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
). - [x ] I ran all tests on my computer and it's all green (i.e.
invoke test
). - [x] I ran lint on my computer and there are no errors (i.e.
invoke lint
). - [ ] I added new functions/classes and made them available on a second-level import, e.g.
compas.datastructures.Mesh
. - [x ] I have added tests that prove my fix is effective or that my feature works.
- [x ] I have added necessary documentation (if appropriate)
@baehrjo #1130 is merged. please resolve the conflicts by merging main into your PR branch so we can get this one done as well...
@baehrjo i think you still need to merge main back into your branch, or rebase it onto main...
Hello,
Sorry for the delay, done!
Best regards,
Joelle
On 24 Oct 2023, at 20:57, Tom Van Mele @.***> wrote:
@baehrjohttps://github.com/baehrjo i think you still need to merge main back into your branch, or rebase it onto main...
— Reply to this email directly, view it on GitHubhttps://github.com/compas-dev/compas/pull/1153#issuecomment-1777843427, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3MW2RUQAIQWT7D7SXWQ5SLYBAFRPAVCNFSM6AAAAAAY7M6N3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZXHA2DGNBSG4. You are receiving this because you were mentioned.Message ID: @.***>