Comonicon.jl icon indicating copy to clipboard operation
Comonicon.jl copied to clipboard

Latency increase from 1.10 to 1.11

Open jakobnissen opened this issue 1 year ago • 6 comments

A small CLI tool I created had its latency go from 0.9 s to 2.7 s when going from Julia 1.10 to 1.11. This might be due to REPL and Pkg being moved out of the system image.

In total, Comonicon brings in 40 transitive dependencies. That seems like a lot. Perhaps an approach to reducing Comonicon's latency is to cut dependencies.

jakobnissen avatar Apr 23 '24 06:04 jakobnissen

This is exactly why I proposed this https://github.com/JuliaLang/julia/discussions/48819. This is not sustainable if we require downstream developers to change their implementation every time something is changed upstream.

I'm not sure which downstream dependency has latency changes. Comonicon only has 4 direct non-stdlib dependencies, which is why it doesn't matter that much before 1.11. Again if we require downstream packages with only 4 direct dependencies (now perhaps 5 or 6) to update its code, this is a very big red flag in maintaining the ecosystem. I'd rather just switch to rust.

Roger-luo avatar Apr 23 '24 13:04 Roger-luo

OK, so it turns out the current solution should be moving the Docs.doc query implementation out of the REPL package.

Roger-luo avatar Apr 28 '24 17:04 Roger-luo

If https://github.com/JuliaLang/julia/pull/54499 indeed lands and is backported to 1.11, then REPL might not be needed, and can be removed from the dependencies (REPL will be available in versions of Julia before 1.11). Then this issue would be solved.

jakobnissen avatar May 21 '24 09:05 jakobnissen

I've been trying to investigate this from https://github.com/JuliaLang/julia/issues/55171 but cannot build the reproducer. Can anyone help over there?

IanButterworth avatar Jul 19 '24 20:07 IanButterworth

Bump. I'm interested in investigating this if someone can help

IanButterworth avatar Jul 24 '24 18:07 IanButterworth

Sorry I got Covid after JuliaCon. I replied in that issue, please let me know if it works for you.

Roger-luo avatar Jul 25 '24 02:07 Roger-luo