zip icon indicating copy to clipboard operation
zip copied to clipboard

Laravel 8 - monolog 2

Open cord opened this issue 4 years ago • 3 comments
trafficstars

Hey guys,

great work - have been using this package for years!

However I am facing following dependency issue:

 - comodojo/foundation 1.0.0 requires monolog/monolog ^1.0 -> found monolog/monolog[1.0.0, ..., 1.26.0] but the package is fixed to 2.2.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
 - comodojo/zip 3.1.0 requires comodojo/foundation ^1.0 -> satisfiable by comodojo/foundation[1.0.0].

So would be great if you would update comodojo/foundation to run on monolog 2

cord avatar Jan 25 '21 17:01 cord

Hey, thanks for the appreciation! :)

The unstable branch (dev-master) is now compatible with monolog2, however the foundation package needs more refactoring and tests before being tagged as stable (if you want to hep, consider opening a PR).

I'm planning to release both foundation 2.0 and zip 3.2 in the next few weeks; until then, I'll keep this issue opened.

marcogiovinazzi avatar Jan 30 '21 14:01 marcogiovinazzi

Thanks a lot, just updated to "comodojo/zip": "dev-master" but have folloing issue:

The previously working code (see https://docs.comodojo.org/projects/zip/en/latest/zipmanager_usage.html )

$addZip = $manager->addZip(\Comodojo\Zip\Zip::open($ZipFileA))->addZip(\Comodojo\Zip\Zip::open($ZipFileB));

is now throwing the error

Undefined class constant 'ZipArchive::EM_NONE'

and in PHPStorm it says

Expected parameter of type '\Comodojo\Zip\Zip', '\Comodojo\Zip\Interfaces\Zip|\Comodojo\Zip\Interfaces\ZipInterface' provided

cord avatar Feb 01 '21 09:02 cord

@cord this fatal error is usually related to a PHP interpreter not compiled against libzip >= 1.2.0, that is a strict requirement of comodojo/zip > 2.0 (please take a look at https://github.com/comodojo/zip/issues/8#issuecomment-613121993). Which OS/PHP version are you using?

Also, please note that dev-master points to the development branch, I would not suggest to use it in production.

The warning PHPStorm is raising is related to a wrong type declaration, I just fixed it. Thanks for spotting this! :)

marcogiovinazzi avatar Feb 02 '21 00:02 marcogiovinazzi