BUG: Fix building libraries as static modules

Open WubiCookie opened this issue 6 years ago • 2 comments

Static building were not handled - although the CTK_BUILD_SHARED_LIB option is present - and raised inconsistent dll linkage errors when compiling.

Dec 16 '19 17:12 WubiCookie

Thanks for your contribution. Could you explain why did you have to introduce MY_LIBRARY_TYPE (why using CTK_LIBRARY_MODE was not sufficient)? What operating system/compiler configurations you had problems with and what configurations you used for testing your solution?

@jcfr can you have a look?

Dec 18 '19 21:12 lassoan

Hi! I did this fix with an earlier version of CTK and MY_LIBRARY_TYPE was needed at the time for CMake to configure without error (I can't remember what error since I fix it some time ago now). I've just tried removing it and it works with the PR version, so I guess we don't need it anymore. I work on Windows 10 with Visual Studio 16 2019 and MSVC 19.23.28106.4. I tested the solution only on the same computer.

Dec 19 '19 11:12 WubiCookie