CTK solve internationalization problems when using ctk dicom widget with languages other than english

solve internationalization problems when using ctk dicom widget with languages other than english

Open CodingFatman opened this issue 6 years ago • 2 comments

the modifications below aim to solve the internationalization problem when people who want to use different language to display information when using CTK DICOM Library

the details are described as below: 1、ctkDicomTableView add a new private member QLabel to store the internal use of queryTableName, use the original QLabel just to display the table view's caption on ui. add function setDisplayText to set the table view's caption on ui add a function applyHeaderTextList to supply a way to use different language formating the table column title

2、ctkDICOMQueryRetrieveWidget set the ctkDICOMQuery Parameters with QApplication::translate() result to solve the internationalization problem

3、ctkDICOMServerNodeWidget modify addServerNode function to set the table widget column title with QApplication::translate() result to solve the internationalization problem modify readSettings function to set the default server node parameters with QApplication::translate() result to solve the internationalization problem

4、ctkDICOMTableManager modify init function, add function call of setDisplayText to patientsTable,studiesTable and seriesTable to format the table view caption with different language

Jun 22 '18 07:06 CodingFatman

@pieper request changes have been modified

Jun 26 '18 06:06 CodingFatman

@pieper all request have been finished

Jun 27 '18 06:06 CodingFatman

We have received grant funding for translation of Slicer to French and Spanish, so we would like to revive and integrate this pull request. We'll set up crowdsourcing translation on Weblate.

One change that I would consider making is to generate one single .ts file for entire CTK instead of one .ts file for each component (ctkDICOM2, ctkDICOMQueryRetrieve, etc.). Having less .ts files would make managament of translations a bit easier: we would have one .ts file for each major component (Slicer, CTK, and for each extension, about a total of 100) for each language - a total of 1000-2000 files. If we had a .ts file for each component then we could end up with tens of thousands of very small .ts files.

@pieper @mhdiop @nolden