commontk
ctkDICOMIndexer::addFile leaves the impression that one could define the destination directory
The above mentioned method leaves the impression that developers could define the output directory to which the delivered file should be copied.
Looking at [1] I noticed, that the parameter will only be used for indication if the file should be kept in position (only a link) or should be copied to the database directory.
Why did you implement it that way and why are you not just using a boolean parameter which is less misleading?
[1] https://github.com/commontk/CTK/blob/cdb75ce742f618112b8a0f299a484d00baa4e8ff/Libs/DICOM/Core/ctkDICOMIndexer.cpp#L88-L101
This was a leftover from the pre-CTK code that we imported. I agree it's a bad API choice and should be fixed.
On Fri, Dec 2, 2016 at 3:04 PM, Christian Herz [email protected] wrote:
The above mentioned method leaves the impression that developers could define the output directory to which the delivered file should be copied.
Looking at [1] I noticed, that the parameter will only be used for indication if the file should be kept in position (only a link) or should be copied to the database directory.
Why did you implement it that way and why are you not just using a boolean parameter which is less misleading?
[1] https://github.com/commontk/CTK/blob/cdb75ce742f618112b8a0f299a484d 00baa4e8ff/Libs/DICOM/Core/ctkDICOMIndexer.cpp#L88-L101
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/commontk/CTK/issues/680, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHsfVXoC6vfpXUDgZzr5lBDmKpUi0dKks5rEHnDgaJpZM4LC7-2 .
