apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

If a category has exact name entered, show it first

Open nicolas-raoul opened this issue 8 years ago • 14 comments

WIth the latest Git, yesterday I got this situation: I typed the name of a category that I know exists, but I had a hard time finding it, because it was far down in the suggestions.

My suggestion: If a category has exact name entered (ignoring uppercase/lowercase), show it first

nicolas-raoul avatar Aug 14 '17 03:08 nicolas-raoul

Agreed, that would be good!

misaochan avatar Aug 14 '17 08:08 misaochan

You could design the search method to check for similarities ignoring caps, then by simple calculation decide if by how much percentage the query matches a category. Then sort the results from highest match to lowest.

ismailisimba avatar Aug 16 '17 06:08 ismailisimba

@ismailisimba Something similar has already been implemented by @misaochan, please see https://github.com/commons-app/apps-android-commons/wiki/Category-suggestions-%28readme%29 Cheers!

nicolas-raoul avatar Aug 16 '17 07:08 nicolas-raoul

Is the issue still open? if yes, can i work on it ?

Kartikdot avatar Aug 24 '17 13:08 Kartikdot

@Kartik2016 Please feel free, thanks! :)

misaochan avatar Aug 24 '17 15:08 misaochan

If @Kartik2016 doesn't work on this issue, I'd like to fix this :)

pszklarska avatar Sep 05 '17 15:09 pszklarska

Oh, sorry for not assigning this one in time... It seems that both @Kartik2016 and @pszklarska started working on it at the same time. Apologies for the confusion, this time I guess it makes sense to assign it to @pszklarska who has sent a pull request already. In the future we will try to assign sooner!

nicolas-raoul avatar Sep 05 '17 16:09 nicolas-raoul

Hum, looks like Github does not allow me to assign to anybody outside the organization, actually! This means we need another way to indicate that an issue is assigned... maybe a label? In any case we will need to make that explicit in the documentation.

nicolas-raoul avatar Sep 05 '17 16:09 nicolas-raoul

Yeah, the assignment is messy. :/ Maybe we could just state in comments "assigned to [name]", along with adding that label?

misaochan avatar Sep 06 '17 05:09 misaochan

Strangely I still see this problem recently, the category with the entered name is very far in the list of suggestions: screenshot_20180122-143127 screenshot_20180125-144542 screenshot_20180125-144605

nicolas-raoul avatar Feb 27 '18 08:02 nicolas-raoul

@nicolas-raoul This is strangely weird. I tried with exactly the ones you tried, and they're appearing at the top of list for me :-/

gupta-meghna64 avatar Mar 18 '18 10:03 gupta-meghna64

@gupta-meghna64 I am using the Play Store beta version, I guess this has been fixed in master? :-)

nicolas-raoul avatar Mar 22 '18 08:03 nicolas-raoul

Yes @nicolas-raoul :)

gupta-meghna64 avatar Mar 23 '18 17:03 gupta-meghna64

Happening currently in 2.8-release branch: screenshot_20180720-004644

nicolas-raoul avatar Jul 21 '18 03:07 nicolas-raoul