apps-android-commons
apps-android-commons copied to clipboard
commons-app
When coming from nearby banner, Nearby pin details of other pins get modified
Step 1: Wait for Nearby notification banner to appear (you have to be near a Wikidata item with no picture, use FakeGPS app if needed).
Step 2: Tap that banner. You are lead to the Nearby activity where the element's pin appears in purple.
Step 3: Tap any other pin. Its details appear:
Problem: After a few seconds, the details get replaced with the details of the notification's element.
Screencast showing all steps:
https://github.com/user-attachments/assets/bcf0b58b-7744-4131-9a27-047592b16b97
I guess it is because of the new way to load pins (turning them from grey to red/green) little by little rather than in one go. This happened to me with a WLM pin but I don't think WLM is a root cause.
That's weird, I was following up your step, but I did not implement the bug. Using Galaxy S20 Android 13
Oh, I should put myself into as much as pins. I Implement that. I think it might be some memory issue or an internet issue. Caz, when u on a small number of pins, this issue will not happen. Can I take this issue?
I just tried at another place and indeed no problem there...
If anyone can reproduce reliably, please let us know, thanks!
I can reproduce this issue consistently. Looking for a fix. Please assign me.
Someone wrote this comment, that says it should highlight the nearest place when we arrive on the Nearby screen through the banner. Is this a bug or a feature?
I believe this code is for step 2 of the issue description above, it is expected and fine. The problem is after step 3: The correct details (of the pin I tapped) are replaced with the details of the banner's place.
Check the screencast above to understand what is wrong, here are screenshots of the key moments of the screencast.
Correct at second 9:
Incorrect at second 10:
I tried the steps you mentioned and found that the details of the bottom card are only replaced by the notification element when I move the screen a little bit. This means the map refreshes and then details get updated.