apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

My Rank button in the Leaderboard takes too long

Open RitikaPahwa4444 opened this issue 1 year ago • 4 comments

What is the user problem or growth opportunity you want to see solved?

Currently, the My Rank button in the leaderboard scrolls through the entire list of contributors to find the rank corresponding to the user requesting for it. This process takes over a minute (I have around 1900 uploads with rank over 5k).

How do you know that this problem exists today? Why is this important?

No response

Who will benefit from it?

App users

Anything else you would like to add?

Screen Recording:

https://github.com/user-attachments/assets/ef071981-c0fa-4f46-af06-671ce7859b9f

RitikaPahwa4444 avatar Jul 13 '24 05:07 RitikaPahwa4444

Can i work on this issue ?

Akshaykomar890 avatar Jul 22 '24 19:07 Akshaykomar890

Hi @Akshaykomar890 and thanks for your interest!

Would you mind choosing a bug from the list at https://github.com/commons-app/apps-android-commons/issues?q=is%3Aopen+is%3Aissue+no%3Aassignee+-label%3Adebated+label%3Abug+-label%3A%22low+priority%22 ?

Per https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md#developers

Thank you! :-)

nicolas-raoul avatar Jul 23 '24 02:07 nicolas-raoul

I think we should remove this functionality and the My Rank button. It doesn't make sense to scroll down to view our details.

rohit9625 avatar Sep 16 '24 07:09 rohit9625

The My Rank button is very useful to see your place in the dashboard. I think it is also fun to use, you get a sense of how close or far you are to the top in a visual and midly entertaining way. You can also compare with other Wikipedians of similar level, who you might be or get familiar with.

By the way it loads well for me, not slow:

https://github.com/user-attachments/assets/42919551-8d39-4bda-a4d3-07722e5acd5d

nicolas-raoul avatar Sep 18 '24 02:09 nicolas-raoul

The My Rank button is very useful to see your place in the dashboard. I think it is also fun to use, you get a sense of how close or far you are to the top in a visual and midly entertaining way. You can also compare with other Wikipedians of similar level, who you might be or get familiar with.

By the way it loads well for me, not slow:

Since you rank below 1000 it seems fine. But if for an instance if a user is having rank 10000+ it will constantly scroll and traverse 10K rank and reach there. Check this https://github.com/commons-app/apps-android-commons/issues/6019#issue-2728984853, it tooked me a minute to traverse till 7k rank. Wdyt?

neeldoshii avatar Dec 11 '24 09:12 neeldoshii

My idea is we can jump to nearest position from the target's, let's say target - 50 (will probably need some animation here too like fading) and then we can just smooth scroll to the actual target, this will preserve our smooth animation as well as, will be fast enough to not wait around to smooth scroll to a very long list.

I'd like to try this out.

parneet-guraya avatar Dec 15 '24 22:12 parneet-guraya

it tooked me a minute to traverse till 7k rank.

@parneet-guraya How would you address this? Maybe not show the list (or show something different) if rank is above 1000?

nicolas-raoul avatar Dec 16 '24 04:12 nicolas-raoul

Look how telegram animates with huge items to traverse through (65K +)

https://github.com/user-attachments/assets/30ee6824-5e64-4700-b0ef-84b2691122fa

and here items are fewer.

https://github.com/user-attachments/assets/108bbbf7-9b5e-4dc9-a5ad-4327eff8fdc6

Animation like this looks fine but our target items should be loaded instantly if there's a delay we might have to show placeholder like shimmer

OR

When clicked on my rank we can just show the shimmer and when loading finishes just show the list. This would be helpful if there's a slight delay in loading rank. I don't how telegram does it. I doubt it is doing caching but not sure.

parneet-guraya avatar Dec 17 '24 02:12 parneet-guraya

I think Telegram already has all of these messages downloaded locally, whereas we are loading them from the Internet.

Placeholders are a great idea, we can show empty slots until the user stops on one, then load the right page of usernames to show that area.

nicolas-raoul avatar Dec 17 '24 03:12 nicolas-raoul