apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Completely do away with the doNotAskForLocationPermission global state

Open sivaraam opened this issue 4 months ago • 1 comments

We have a global state in our app with the key doNotAskForLocationPermission. It seems to be complicate understanding of the code flow more difficult than it should be. We need to explore ways to completely remove the same and handle it in other ways that are more maintainable.

The following is the PR comment that led to the creation of this issue: https://github.com/commons-app/apps-android-commons/pull/5494#discussion_r1518566915

That PR seems to already reduce our dependence on the doNotAskForLocationPermission global state to some extent. This issue is about refactoring the code such that we no longer need it at all. Feel free to propose solutions that could help us achieve this.

sivaraam avatar Mar 30 '24 17:03 sivaraam