apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Published 20 hours ago • verified publisher icon commons-app

When "Show already actioned pictures" disabled, Custom picker does not check uploaded-or-not status for never seen pics

Open nicolas-raoul opened this issue 1 year ago • 2 comments

  1. Reset the app
  2. Download https://upload.wikimedia.org/wikipedia/commons/4/4c/Bar-bellied_Pitta.jpg
  3. Start the app
  4. Open custom picker
  5. Tap your "Camera" album (not "Download")
  6. Disable "Show already actioned pictures"
  7. Go back
  8. Tap your "Download" folder
  9. Problem: tHe Pitta pic shows up, even though it is already on Commons.

It seems like the app only verifies checksums when "Show already actioned pictures is enabled.

nicolas-raoul avatar Mar 25 '24 13:03 nicolas-raoul

It's barely repeatable for me. At first, it behaved just like you described, but in the second and all after trials, it just worked like it needed to be. Even after show actioned pictures was disabled, the image didn't show up. That means the app verifies the checksum when that switch is disabled.

rohit9625 avatar Mar 26 '24 04:03 rohit9625

Example on latest main branch, even though "show already actioned images" is disabled, the already uploaded "pachinko" picture is shown. Then after enabling the switch the app finally does the proper checksum API call.

https://github.com/commons-app/apps-android-commons/assets/99590/a1a3a730-3625-4ecd-ad91-7cb74b183e08

nicolas-raoul avatar Apr 01 '24 04:04 nicolas-raoul