apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

[Bug]: Sub Categories and Parent Categories should be shown if available

Open rohit9625 opened this issue 1 year ago • 3 comments

Summary

When I browse the category on a details page of an upload, I see the blank sub-categories and parent categories page. For some categories, there are no sub and parent-categories available. So in that case, we should display a message(e.g. using Snackbar or maybe just showing text in the middle of the screen). Also, the screen is still blank for some categories despite having sub-categories available on the category page.

Steps to reproduce

  1. Open any image(self uploaded or from the Explore tab) details page
  2. Click on any category from the Categories section
  3. Switch to sub-categories tab
  4. You'll see a blank screen even sub-categories are available on the category page

Expected behaviour

There should be a message similar to this No sub-categories available, if not available. And should show the sub-categories list if available.

Actual behaviour

The screen is blank with no response message.

Device name

SAMSUNG A14

Android version

ANDROID 14

Commons app version

4.2.1

Device logs

No response

Screen-shots

WhatsApp Image 2024-03-16 at 09 12 43_a5f2568e WhatsApp Image 2024-03-16 at 09 12 43_a418479e

Category Page WhatsApp Image 2024-03-16 at 09 12 42_f5c05f2b

Would you like to work on the issue?

Yes

rohit9625 avatar Mar 16 '24 04:03 rohit9625

I would say showing text in the middle of the screen is the best, rather than a snackbar :-)

nicolas-raoul avatar Mar 23 '24 13:03 nicolas-raoul

Doesn't it already say No subcategories found ? E.g. in latest F-droid release 4.2.1~14b6c455b on Android 14:

https://github.com/commons-app/apps-android-commons/assets/156656/42f34763-7fa9-462b-accc-757085fdaeea

Perhaps it only happens in some specific cases? Of I misunderstood how to reproduce it?

mnalis avatar Apr 13 '24 17:04 mnalis

Somehow category search isn't even working for me.

nicolas-raoul avatar Apr 16 '24 07:04 nicolas-raoul

Thanks for discovering this bug! I will close in favor of #5758, thanks for your understanding.

nicolas-raoul avatar Aug 20 '24 08:08 nicolas-raoul