apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Add label "Congratulations, all pictures in this album have been either uploaded or marked as not for upload."

Open nicolas-raoul opened this issue 1 year ago • 13 comments

In the custom picker, with "Show already actioned pictures" disabled, this is how the screen looks after all pictures have been either uploaded or marked as not for upload:

Screenshot_20240310-162611.png

Ideally, it should instead display a message such as:

"Congratulations, all pictures in this album have been either uploaded or marked as not for upload."

nicolas-raoul avatar Mar 10 '24 11:03 nicolas-raoul

Can we either display "An vector" like this?

If no image is left to upload or masked as not for upload, we can display svg image & display text like

  1. Custom Picker finalised: Every image is now either uploaded or marked.
  2. Album perfection achieved: Every photo uploaded or sorted. I don't think congratulations is right word as if some person has marked all images not for upload will get text congratulation might be incorrect from UX copywriting pov.

image Credits

What do you think about it @nicolas-raoul. I can tackle this while my wikimedia id is banned.

neeldoshii avatar Mar 12 '24 16:03 neeldoshii

@neeldoshii Sorry for the delay! Yes vetor image would be nice, if possible.

"Congratulations": Even marking all pictures as not for upload is good, so I think it is a good opportunity to make people feel good. :-) Maybe something like "Good job! [...]"

Maybe it could even suggest the user to perform peer reviews or go take nearby pictures, with buttons to launch these activities.

nicolas-raoul avatar Mar 25 '24 01:03 nicolas-raoul

I would like to try to solve this problem. Would you like to assign it to me?

starrain1031 avatar Apr 15 '24 04:04 starrain1031

I would like to try to solve this problem. Would you like to assign it to me?

Are you still working on this issue ?

Thejas775 avatar Apr 17 '24 21:04 Thejas775

I would like to try to solve this problem. Would you like to assign it to me?

Are you still working on this issue ?

Yes. However, based on my limited skills, it might take me sometime.

starrain1031 avatar Apr 18 '24 06:04 starrain1031

@Thejas775 Thanks for your enthusiasm, however better work on unassigned bugs (the app has enough bugs for everybody haha) next time.

@starrain1031 Sorry for unusual workflow this time. Maybe review Thejas775's pull request, improve it if possible, then work on a second bug if you want? :-)

nicolas-raoul avatar Apr 18 '24 13:04 nicolas-raoul

I'm really sorry but this was my first contribution to open source as well. This was a good first issue that I thought I could solve.

Thejas775 avatar Apr 18 '24 14:04 Thejas775

@Thejas775 That's understandable :-) You might want to read https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md#developers which has the link to unassigned bugs. I hope you will enjoy fixing other bugs :-)

nicolas-raoul avatar Apr 18 '24 14:04 nicolas-raoul

@Thejas775 Thanks for your enthusiasm, however better work on unassigned bugs (the app has enough bugs for everybody haha) next time.

@starrain1031 Sorry for unusual workflow this time. Maybe review Thejas775's pull request, improve it if possible, then work on a second bug if you want? :-)

Will follow the workflow from next time.

Thejas775 avatar Apr 18 '24 14:04 Thejas775

@Thejas775 That's understandable :-) You might want to read https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md#developers which has the link to unassigned bugs. I hope you will enjoy fixing other bugs :-)

Yeah sure seems intresting.

Thejas775 avatar Apr 18 '24 14:04 Thejas775

@starrain1031 Any progress on this? :-)

nicolas-raoul avatar Aug 20 '24 08:08 nicolas-raoul

@starrain1031 Any progress on this? :-)

If @starrain1031 is not working on this. I can do this.

AlexD4110 avatar Sep 17 '24 01:09 AlexD4110

@AlexD4110 Thanks for your enthusiasm! I just assigned you to the other issue, when done please ask again here. Thanks a lot! :-)

nicolas-raoul avatar Sep 17 '24 02:09 nicolas-raoul

Hi, can i work on this issue @nicolas-raoul

yuvraj-coder1 avatar Dec 30 '24 19:12 yuvraj-coder1