apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Fixed Clicking on edit photo shows default rotation

Open kanahia1 opened this issue 1 year ago • 5 comments
trafficstars

Description (required)

Fixes #5502

What changes did you make and why?

Tests performed (required)

Tested prodDebug on Samsung S21 FE with API level 33.

Screenshots (for UI changes only)

https://github.com/commons-app/apps-android-commons/assets/114223204/ec05903d-82ed-428f-b71e-42cc4c7da848

kanahia1 avatar Feb 28 '24 17:02 kanahia1

@shashankiitbhu, I am still facing an error

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:mergeBetaDebugResources'.
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:149)
	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:2[82](https://github.com/commons-app/apps-android-commons/actions/runs/8114615843/job/22180660355?pr=5575#step:10:83))
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:147)

kanahia1 avatar Mar 01 '24 17:03 kanahia1

@kanahia1 For this you can just remove the folder for yue-hant.

My review wasn't related to this, I was building the app after removing this, your pull request is failing to build even after removing this folder.

Please try building it after removing this folder and you will see other errors.

shashankiitbhu avatar Mar 01 '24 17:03 shashankiitbhu

Oh, Looking into it! Will share PR asap ;)

kanahia1 avatar Mar 24 '24 11:03 kanahia1

Did you get a chance to look at this, maybe? :-)

nicolas-raoul avatar Apr 01 '24 08:04 nicolas-raoul

Fixed the animation issue, but it landed me into another issue. Trying to fix it!

https://github.com/commons-app/apps-android-commons/assets/114223204/c5d1d193-d284-4c75-84de-f47c27521bd0

kanahia1 avatar Apr 01 '24 17:04 kanahia1