apps-android-commons
apps-android-commons copied to clipboard
commons-app
Depictions picker shows labels in OS language instead of app interface language
OS in Chinese App interface in French (in the Commons app's settings) Labels should be shown in French, but they are actually shown in Chinese:
Same for license selection:
Hi, can I take this issue? I find this interesting. Would you have more information to provide? I figure for some languages it doesn't even translate the popup window or it may only be partially translated.
@u7452206 It is yours :-)
I suggest testing with OS in Chinese and app in French. Solving for this will most probably fix the issue for all other languages.
for some languages it doesn't even translate the popup window or it may only be partially translated
That's because translations are not complete, which is not really a bug. :-)
The bug here is that even though there are French localizations for "London" and "Creative Commons", they are not shown when the app is set to French.
I also found out there are inconsistencies. The Chinese names for London appears in both traditional and simplified.
Could I please know which file do you use to edit language function ? Would love to know what you have tried to solve this issue and work from there.
The traditional/simplified inconsistency you found is due to Wikidata, we do not have to worry about it. :-)
I have not tried to solve it. Your task is to find the part of the source code which selects the language for the data filled into those screens.
The license one (step 4) is probably the easiest to find. The depictions one (step 2) is probably related to a parameter in a Wikidata query.
@u7452206 Did you get a chance to check my comment on your pull request at https://github.com/commons-app/apps-android-commons/pull/5364#issuecomment-2022237940 ? Thanks a lot. :-)
@u7452206 I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-)