[Bug]: Improve the media location access dialog strings

[sivaraam]

Summary

We show a dialog requesting for media location access permission so that we would be able to access the location from images. The title and description of that dialog are as follows:

Title: Media location access denied Description: We may not be able to automatically obtain location data from pictures you upload. Please add the appropriate location for each picture before submitting

This is completely misleading since hitting "Ok" on that dialog is shown right before we request for the permission. The strings are appropriate to be shown only if we shown them right after knowing that we're denied that permission.

We need to tweak the code such that we show an appropriate string before requesting for the media location permission. We could show the above string if we're denied that permission for some reason.

Steps to reproduce

1. "Freshly" install app from master branch
2. Login to the app
3. Note the description in the "Media location access" permission dialog
4. Hit on "Ok"
5. Observe that you're shown the dialog requesting for media access

Expected behaviour

We should show an dialog stating why we need the media location access permission. If we're denied the permission, we should show the existing description shown above.

Actual behaviour

We're showing a dialog with the existing description above before requesting access to the media location permission.

Device name

OnePlus Nord

Android version

Android 12

Commons app version

master @ Sep 04

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

None