apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Replaced Toasts With Snackbars in AchievementsFragment and Leaderboard

Open shankarpriyank opened this issue 2 years ago • 6 comments
trafficstars

Description (required)

Fixes #2388

What changes did you make and why? Replaced Toasts With Snackbars in AchievementsFragment and Leaderboard

shankarpriyank avatar Apr 22 '23 08:04 shankarpriyank

It's a bit weird, the tests which are failing in the CI are passing when I test them locally.

shankarpriyank avatar Apr 22 '23 09:04 shankarpriyank

Also, the achievement, leaderboard, and contribution fragments are loading and showing relevant information in the beta flavor, which I guess is not the intended behaviour

shankarpriyank avatar Apr 22 '23 09:04 shankarpriyank

I think that our achievements calculation server use the production server directly and has no beta version, it was deemed acceptable since it is read-only.

nicolas-raoul avatar Apr 22 '23 22:04 nicolas-raoul

I think that our achievements calculation server use the production server directly and has no beta version, it was deemed acceptable since it is read-only.

Okay, but we still need to fix the tests..

shankarpriyank avatar Apr 22 '23 22:04 shankarpriyank

@nicolas-raoul could use some help here

shankarpriyank avatar May 02 '23 12:05 shankarpriyank

As we have defined Snackbar functions in file Util.java. So, it would help if you used them as Snackbars. @shankarpriyank

rohit9625 avatar Feb 23 '24 08:02 rohit9625