apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

4664: Moved ImageFragment to ViewBinding

Open bosankus opened this issue 2 years ago • 1 comments

Fixes #4664

What changes did you make and why?

  • Issue: As per the information provided and work request on the ticket above, ImageFragment.kt is currently using Kotlin Synthetic which creates auto-generated class, and has been alread deprecated.
  • Solution: Hence migration was done by replacing kotlin-synthetic with viewbinding, which is always null safe, type-safe and supports both Java and Kotlin.

NB: During migration a redundant semicolon was removed.

bosankus avatar Oct 09 '22 20:10 bosankus

@dbrant Requesting to review this PR

bosankus avatar Oct 09 '22 20:10 bosankus

Thanks @bosankus and sorry for the long wait!

nicolas-raoul avatar Oct 29 '22 08:10 nicolas-raoul