apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Published 20 hours ago • verified publisher icon commons-app

4664: Moved WelcomeActivity to ViewBinding

Open bosankus opened this issue 3 years ago • 3 comments

Fixes #4664

What changes did you make and why?

  • Issue: As per the information provided and work request on the ticket above, WelcomeActivity.java is currently using Butterknife to to inject views into Android components.
  • Solution: Hence migration was done by replacing butterknife with viewbinding, which is always null safe, type-safe and supports both Java and Kotlin.

bosankus avatar Oct 03 '22 20:10 bosankus

Hi @psh , I need little help regarding error showing on WelcomeActivityUnitTest.kt file. Run test step failed due to error on this file, and says below:

Screenshot 2022-10-09 at 7 11 07 AM

I made the changes as it says in these lines, but I kept getting error.

I tried to run other test classes , like AccountUtilUnitTest.kt and it have failes due to same problem -

Could not initialize plugin: interface org.mockito.plugins.MockMaker (alternate: null)

Refer to the error image below please. Screenshot 2022-10-09 at 7 08 21 AM

I can see one of your PR #4702 have been merged without any test class file changes. Requesting help to fix/merge this PR

bosankus avatar Oct 09 '22 01:10 bosankus

@dbrant Requesting to review this PR

bosankus avatar Oct 09 '22 20:10 bosankus

Hi @psh Can you review this PR?

bosankus avatar Oct 14 '22 20:10 bosankus